v4 API: Mock Refresh Token Test #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e `get_access_token_by_api_key_and_secret`
n7studios
requested review from
a team,
noelherrick and
jenessawhite
and removed request for
a team
…into v4-api-rename-access-token-api-key-method
noelherrick
approved these changes
May 17, 2024
…-key-method v4 API: Rename Exchange API Key and Secret Method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mocks the
testRefreshTokentest, otherwise the newly issued access and refresh tokens (rightly) mean our existing access and refresh tokens stored in the .env file are invalidated, and therefore later tests fail.Previously, tests would pass without mocking this call. Possibly a change in doorkeeper 5.7.0 that revokes existing credentials / grants when refreshing an access token.
Testing
Existing tests pass
Checklist