Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4 API: Encode state parameter #72

Merged
merged 6 commits into from
Jun 28, 2024
Merged

v4 API: Encode state parameter #72

merged 6 commits into from
Jun 28, 2024

Conversation

n7studios
Copy link
Contributor

Summary

Base64URL encodes the state parameter with the necessary return_to and client_id data required for the ConvertKit hosted universal redirect URL.

Testing

  • testGetOAuthURLWithState: Updated test to assert state parameter contains the correct data.

Checklist

@n7studios n7studios added the enhancement New feature or request label Jun 26, 2024
@n7studios n7studios added this to the 2.0 milestone Jun 26, 2024
@n7studios n7studios self-assigned this Jun 26, 2024
@n7studios n7studios requested review from a team, noelherrick and corydhmiller and removed request for a team June 26, 2024 15:24
@n7studios n7studios marked this pull request as ready for review June 26, 2024 15:25
Copy link

@noelherrick noelherrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note, the redirect endpoint only accepts the WordPress app (client_id) right now, so if there are others, we should add them to this list so the redirect works.

@n7studios n7studios merged commit cc8dbfd into v4-api Jun 28, 2024
5 checks passed
@n7studios n7studios deleted the v4-api-encoded-state branch July 19, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants