Fix Landing Page `html` tag detection #81

n7studios · 2024-09-25T04:31:36Z

Summary

Fixes this reported issue by checking for any <html> tags, such as <html lang.

Before:

After:

testGetLandingPageHTML: Confirm original <html lang="en"> is preserved
testGetLegacyLandingPageHTML: Confirm <html> tag was added, as this isn't included when fetching legacy landing pages.

I have written a test and included it in this PR
I have run all tests and they pass
The code passes when running the PHP CodeSniffer
Code meets WordPress Coding Standards for PHP, HTML, CSS and JS
Security and Sanitization requirements have been followed
I have assigned a reviewer or two to review this PR (if you're not sure who to assign, we can do this step for you)

n7studios added 2 commits September 25, 2024 12:26

Don’t replace <html> tag if it is e.g. <html lang=“en”>

0635ccf

Fix tests

6d472c8

n7studios added the bug Something isn't working label Sep 25, 2024

n7studios self-assigned this Sep 25, 2024

n7studios requested review from a team, noelherrick and jenessawhite and removed request for a team September 25, 2024 08:25

n7studios marked this pull request as ready for review September 25, 2024 08:25

noelherrick approved these changes Sep 25, 2024

View reviewed changes

n7studios merged commit 5b107d1 into main Sep 26, 2024
5 checks passed