Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove prepended Cloudflare string from JS script type #82

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

n7studios
Copy link
Contributor

Summary

Fixes this reported issue by ensuring JS type attributes prepended with Cloudflare's randomized string are converted to text/javascript.

We removed rocket-loader.min.js in this PR, as it was breaking redirects on Landing Pages. The side effect of this is JS isn't executing on Landing Pages, as scripts still retained e.g. type="d4d618933d20ff16d2d8ebb4-text/javascript".

Testing

  • Updated tests to check that script types have their prepended random string removed.

Checklist

@n7studios n7studios added the bug Something isn't working label Sep 28, 2024
@n7studios n7studios self-assigned this Sep 28, 2024
@n7studios n7studios requested review from a team, noelherrick and jenessawhite and removed request for a team September 28, 2024 03:26
@n7studios n7studios marked this pull request as ready for review September 28, 2024 03:27
@n7studios n7studios merged commit 345b74c into main Oct 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants