chore(deps): timed-map migration
#2247
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamardy
changed the title
timed-map crate instead of internal ExpirableMap typetimed-map crate instead of internal ExpirableMap
onur-ozkan
reviewed
Nov 6, 2024
Signed-off-by: onur-ozkan <work@onurozkan.dev>
onur-ozkan
force-pushed
the
use-timed-map-crate
branch
from
e2b814e to
ff4038d
Compare
onur-ozkan
added
status: pending review
improvement: dependencies
and removed
status: in progress
labels
onur-ozkan
changed the title
timed-map crate instead of internal ExpirableMaptimed-map migration
onur-ozkan
reviewed
Jan 9, 2025
| @@ -177,7 +177,7 @@ impl ElectrumConnection { | |||
| settings, | |||
| tx: Mutex::new(None), | |||
| establishing_connection: AsyncMutex::new(()), | |||
| responses: Mutex::new(JsonRpcPendingRequests::new()), | |||
| responses: Mutex::new(JsonRpcPendingRequests::new_with_map_kind(MapKind::BTreeMap)), | |||
There was a problem hiding this comment.
Picked BTreeMap intentionally to process entries in order.
There was a problem hiding this comment.
wdym by processing entries in order? what processing?
Signed-off-by: onur-ozkan <work@onurozkan.dev>
mariocynicys
reviewed
Jan 9, 2025
|
|
| @@ -251,7 +251,7 @@ impl ElectrumConnection { | |||
| self.responses | |||
| .lock() | |||
| .unwrap() | |||
| .insert(rpc_id, req_tx, Duration::from_secs_f64(timeout)); | |||
| .insert_expirable_unchecked(rpc_id, req_tx, Duration::from_secs_f64(timeout)); | |||
There was a problem hiding this comment.
the only insert being unchecked basically makes this map susceptible to memory leaks. this acts pretty much similar (with an *) to a normal hashmap at this point.
you can instead make it a checked insert but use a high tick cap.
there are other never-checked maps also introduced in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete timed-map migration from
TimeCache,DuplicateCache,ExpirableMapandExpirableEntry.