Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tendermint): validators RPC #2310

Merged
merged 16 commits into from
Jan 8, 2025
Merged

feat(tendermint): validators RPC #2310

merged 16 commits into from
Jan 8, 2025
+269 −23

Conversation

onur-ozkan
Copy link
Member

@onur-ozkan onur-ozkan commented Jan 2, 2025 •
edited
Loading

This is the initial implementation related to Tendermint staking feature on KDF. Remaining parts will be added gradually one by one similar to the validators RPC in this PR.

e.g., RPC payload structure:

komodo-defi-framework/mm2src/mm2_test_helpers/src/for_tests.rs

Lines 3102 to 3112 in 4c63f6e

let request = json!({
"userpass": mm.userpass,
"method": rpc_endpoint,
"mmrpc": "2.0",
"params": {
"ticker": coin,
"filter_by_status": filter_by_status,
"limit": limit,
"page_number": page_number
}
});

filter_by_status can be set to one of All, Bonded and Unbonded. Default is All.

Explanation of Bonded and Unbonded statuses:

komodo-defi-framework/mm2src/coins/rpc_command/tendermint/staking.rs

Lines 12 to 18 in 43dbf48

/// Validator is in the active set and participates in consensus.
#[default]
Bonded,
/// Validator is not in the active set and does not participate in consensus.
/// Accordingly, they do not receive rewards and cannot be slashed.
/// It is possible to delegate tokens to a validator in this state.
Unbonded,

@onur-ozkan
save dev state
9fc3319 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan
save dev state
a6ebe1c 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan
make proto types serializable for RPC endpoint
9198049 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan
remove dummy test
b48c1ba 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan
add RPC error type
2470594 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan
add TODO
c4df52a 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan
fix status filtering
95d008b 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan
fix clippy warn
61b1654 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan
resolve todo!()s
8d59f4d 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan
remove inline attribute
05eb07e 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan
improve validators_rpc
838bee4 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan
add coverage for tendermint_validators RPC
ee20b9a 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan
apply nit changes
4c63f6e 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan onur-ozkan marked this pull request as ready for review January 6, 2025 06:09
@onur-ozkan
document ValidatorStatus
43dbf48 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
borngraced
borngraced previously approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@borngraced borngraced left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!

@onur-ozkan
use proper error variant on coin filtering
db5cff6 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
mariocynicys
mariocynicys reviewed Jan 6, 2025
View reviewed changes
Copy link
Collaborator

@mariocynicys mariocynicys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank YOU :)

mm2src/mm2_test_helpers/src/for_tests.rs Outdated Show resolved Hide resolved
mm2src/mm2_main/tests/docker_tests/tendermint_tests.rs Show resolved Hide resolved
mm2src/coins/tendermint/tendermint_coin.rs Outdated Show resolved Hide resolved
mm2src/coins/rpc_command/tendermint/staking.rs Outdated Show resolved Hide resolved
mm2src/coins/rpc_command/tendermint/staking.rs Show resolved Hide resolved
mm2src/coins/rpc_command/tendermint/staking.rs Show resolved Hide resolved
@onur-ozkan
apply nits
96306cc 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
mariocynicys
mariocynicys approved these changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@mariocynicys mariocynicys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
LGTM!

@onur-ozkan onur-ozkan merged commit 1908a2e into dev Jan 8, 2025
16 of 23 checks passed
@onur-ozkan onur-ozkan deleted the validator-rpcs branch January 8, 2025 08:12
dimxy added a commit that referenced this pull request Jan 8, 2025
@dimxy
Merge branch 'dev' into fix-utxo-tx-fee-for-change
455403c 
* dev:
  feat(tendermint): validators RPC (#2310)
  chore(CI): validate Cargo lock file (#2309)
  test(P2P): add test for peer time sync validation (#2304)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariocynicys mariocynicys mariocynicys approved these changes

@borngraced borngraced borngraced left review comments

Assignees
No one assigned
Labels
feature: protocol feature: RPC status: pending review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@onur-ozkan @borngraced @mariocynicys