-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSL migration #143
Merged
SSL migration #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`coins_config_ssl` delists coins without SSL support whereas `coins_config_tcp` favours SSL but falls back to TCP if not available.
https://developer.android.com/google/play/requirements/target-sdk Signed-off-by: Kadan Stadelmann <ca333@users.noreply.github.com>
Signed-off-by: Charl (Nitride) <77973576+CharlVS@users.noreply.github.com>
Prefer SSL coin electrum servers
CharlVS
added a commit
that referenced
this pull request
Jul 13, 2024
* update rates url * Add docker image and devcontainer Only Linux and WSL on x86 are supported at the moment * SSL migration (#143) * Update coins to SSL config * Rename references to SSL coin config * Prefer SSL, but fall back to TCP if not available. `coins_config_ssl` delists coins without SSL support whereas `coins_config_tcp` favours SSL but falls back to TCP if not available. * Sync latest TCP file from coins repo * bump target SDK https://developer.android.com/google/play/requirements/target-sdk Signed-off-by: Kadan Stadelmann <ca333@users.noreply.github.com> * Bump app build Signed-off-by: Charl (Nitride) <77973576+CharlVS@users.noreply.github.com> --------- Signed-off-by: Kadan Stadelmann <ca333@users.noreply.github.com> Signed-off-by: Charl (Nitride) <77973576+CharlVS@users.noreply.github.com> Co-authored-by: CharlVS <77973576+CharlVS@users.noreply.github.com> * Replace python script with new dart version Also update dockerfile * Fix issues with new dart script as when used via CLI * Revert "Replace python script with new dart version" This reverts commit 0bde503. * Change from clone to COPY and fix permission issue * Add documentation and fix build directory permission issues * Update devcontainer image and fix permission issues * Fix devcontainer ndk install error Write permission denied to `/opt/android-sdk-linux` * Move changing ownership of android sdk folder to dockerfile * Replace Flutter archive download with git clone of Flutter repo Use a build matching the current architecture rather than downloading a prebuilt archive * Refactor to fetch Defi binaries only from GH releases (#148) * Refactor to fetch Defi binaries from GH releases Refactor to fetch Defi binaries from GH releases since they are built in a secure environment instead of the automated CI builds. * Fix script to use version tag Fix the script to use a version tag instead of a hash, as GH’s API does not support fetching a release tied to a specific commit. In the future, we can investigate if there’s an alternate way to verify/validate that the release build is indeed built from a given hash so we can change from a tag ref to a hash ref. * Fix bug in API fetch script Fix the API binary fetch script Ravioli ravioli * Remove the hardcoded platform from the devcontainer image * Copy over android sdk dockerfile from Cirrus CI Remove references to 3rd party dockerfiles, allow for local image tagging and simplify code review. Credit to https://github.com/cirruslabs/docker-images-android/tree/master * Fix bug in API fetch script Fix bug in API fetch script where fetching would fail if the android lib folders didn’t already exist. * Add script to abstract apk release build * Change devcontainer to docker-compose format Use local tagged image instead of the 3rd party image * Revert "Change devcontainer to docker-compose format" This reverts commit 95ce8bf. * Add note regarding build limitations and the Python script * Update fetch coins scripts * Add komodo-defi-framework build step to apk build image Also standardise base images to ubuntu:22.04 * Fix kdf branch build argument * Remove unnecessary copy Leftover artefact from previous build stage setup * Combine dockerfiles into `android-dev` for Github codespaces * Move API build to postAttach event of devcontainer API was built in image to reduce Codespaces startup time, but ended up increasing the already large image size * Fix cargo install in devcontainer/Codespaces * Set the minimum host requirements for Codespaces 4 cores, 16GB RAM and 32GB storage is the minimum requirements for the API to build successfully from source. --------- Signed-off-by: Kadan Stadelmann <ca333@users.noreply.github.com> Signed-off-by: Charl (Nitride) <77973576+CharlVS@users.noreply.github.com> Co-authored-by: Charl <77973576+CharlVS@users.noreply.github.com> Co-authored-by: smk762 <smk762@iinet.net.au> Co-authored-by: Kadan Stadelmann <ca333@users.noreply.github.com>
CharlVS
added a commit
that referenced
this pull request
Dec 19, 2024
commit 69d98b2 Author: Kadan Stadelmann <ca333@users.noreply.github.com> Date: Mon May 13 12:25:31 2024 +0200 SSL migration (#143) * Update coins to SSL config * Rename references to SSL coin config * Prefer SSL, but fall back to TCP if not available. `coins_config_ssl` delists coins without SSL support whereas `coins_config_tcp` favours SSL but falls back to TCP if not available. * Sync latest TCP file from coins repo * bump target SDK https://developer.android.com/google/play/requirements/target-sdk Signed-off-by: Kadan Stadelmann <ca333@users.noreply.github.com> * Bump app build Signed-off-by: Charl (Nitride) <77973576+CharlVS@users.noreply.github.com> --------- Signed-off-by: Kadan Stadelmann <ca333@users.noreply.github.com> Signed-off-by: Charl (Nitride) <77973576+CharlVS@users.noreply.github.com> Co-authored-by: CharlVS <77973576+CharlVS@users.noreply.github.com> commit 6df3044 Merge: b853544 66471b9 Author: Kadan Stadelmann <ca333@users.noreply.github.com> Date: Sat May 4 22:03:41 2024 +0200 Merge pull request #123 from KomodoPlatform/dev [RC] `0.9.1`: Chart & Order Book Fixes + Sync assets commit b853544 Merge: 68138a3 06947f9 Author: Kadan Stadelmann <ca333@users.noreply.github.com> Date: Wed Jan 24 09:34:50 2024 +0100 Merge pull request #100 from KomodoPlatform/dev sync master commit 68138a3 Merge: b0eb54a 36c6afd Author: Kadan Stadelmann <ca333@users.noreply.github.com> Date: Tue Jan 16 12:59:34 2024 +0100 Merge pull request #93 from KomodoPlatform/dev sync master commit b0eb54a Merge: 8281a1a b4d69d1 Author: Kadan Stadelmann <ca333@users.noreply.github.com> Date: Wed Dec 20 00:53:07 2023 +0100 Merge pull request #91 from KomodoPlatform/dev `0.9.0` RC - Net ID migration and file sharing fixes commit 8281a1a Author: smk762 <smk762@iinet.net.au> Date: Mon Oct 30 16:42:47 2023 +0800 update rates url commit 40b1eb2 Merge: 0f30d51 e32aff7 Author: Charl <77973576+CharlVS@users.noreply.github.com> Date: Fri Oct 20 18:38:35 2023 +0200 0.8.0 Release: Merge pull request #78 from KomodoPlatform/dev 0.8.0 Release (stable): UI revamp, bug fixes and coins update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.