Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update rates url #80

Merged
merged 1 commit into from
Oct 31, 2023
Merged

update rates url #80

merged 1 commit into from
Oct 31, 2023

Conversation

smk762
Copy link
Contributor

@smk762 smk762 commented Oct 30, 2023

Replaced https://rates.komodo.earth/api/v1/usd_rates with https://defi-stats.komodo.earth/api/v3/rates/fixer_io

To test:

  • Change from USD to a few other fiats and confirm the values are sane

@CharlVS CharlVS requested review from naezith, CharlVS and kivqa October 30, 2023 09:45
@CharlVS CharlVS assigned smk762 and unassigned naezith, CharlVS and kivqa Oct 30, 2023
@CharlVS CharlVS added the QA Ready for QA testing label Oct 30, 2023
@CharlVS
Copy link
Member

CharlVS commented Oct 30, 2023

@kivqa Can you please check everything is working as expected?

kivqa
kivqa approved these changes Oct 30, 2023
View reviewed changes
Copy link

@kivqa kivqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.
Fiat rates displayed correctly. Checked for USD, GBP, RUB, TRY
Rates in all place in the app are correct.

@CharlVS CharlVS merged commit 8281a1a into master Oct 31, 2023
1 check failed
@CharlVS CharlVS deleted the update-rates-url branch October 31, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kivqa kivqa kivqa approved these changes

@CharlVS CharlVS CharlVS approved these changes

@naezith naezith naezith approved these changes

Assignees

@smk762 smk762

Labels
QA Ready for QA testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smk762 @CharlVS @naezith @kivqa