-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sessions): store session's meatadata #13990
base: master
Are you sure you want to change the base?
Conversation
30ce6e0
to
7158135
Compare
@bungle Could you take a review for this PR, please? |
The changes in the pull request expose the controls on the |
7158135
to
91d9bd8
Compare
90fd87a
to
d94436f
Compare
72c0fc6
to
66572c8
Compare
@@ -0,0 +1,4 @@ | |||
message: | | |||
**session**: Added two configurations `hash_subject` and `store_metadata` to store session's metadata. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
**session**: Added two configurations `hash_subject` and `store_metadata` to store session's metadata. | |
**session**: Added two boolean configuration fields `hash_subject` (default `false`) and `store_metadata` (default `false`) to store session's metadata in the database. |
If the session data is stored in the cookie, should we care about the session metadata? |
66572c8
to
f8bbf35
Compare
f8bbf35
to
c8be1a7
Compare
Summary
Engineering brief:
https://docs.google.com/document/d/1r7nSZGOlTVhupoVGQ6Ymqsaw64eGHKSMibko8FgrwAQ/edit?tab=t.0
### This PR won't bring a break change.
Add two new configurations
hash_subject
(by default false) andstore_metadata
(by default false). Please ref here.Add a new table
session_metadatas
to store the session's metadata.Why to do this?
Please check this PR's ticket.
Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference
KM-788