Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(balancer): refresh uri and tls scheme in ai-proxy-advanced balancer phase #14007

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat(balancer): refresh uri and tls scheme in ai-proxy-advanced balancer phase #14007

wants to merge 4 commits into from
+334 −1

Conversation

oowl
Copy link
Member

@oowl oowl commented Dec 11, 2024 •
edited
Loading

Summary

  1. feat(patch): backport balancer.set_upstream_tls feature from openresty upstream feature: add balancer.set_upstream_tls(on). openresty/lua-resty-core#460
  2. feat(patch): refresh upstream uri variable when proxy pass balancer recreate
  3. feat(pdk): dynamic control upstream tls when kong.service.request.set_scheme was called
  4. feat(llm): recreate http request header and body when balancer retry

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

AG-183

fffonion
fffonion reviewed Dec 16, 2024
View reviewed changes
kong/llm/plugin/base.lua Outdated Show resolved Hide resolved
@oowl oowl force-pushed the balancer-patch branch 4 times, most recently from 3f51327 to 65d9a31 Compare December 20, 2024 06:22
fffonion
fffonion reviewed Dec 23, 2024
View reviewed changes
build/openresty/patches/nginx-1.25.3_09-refresh-uri-when-proxy-pass-balancer-recreate.patch
+#endif
+
+ } else {
+ if (ngx_http_proxy_eval(r, ctx, plcf) != NGX_OK) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @ADD-SP this would need some performance test to validate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fffonion fffonion fffonion left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

@oowl oowl

Labels
build/bazel cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/pdk plugins/ai-proxy plugins/ai-request-transformer plugins/ai-response-transformer size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oowl @fffonion