fix(certificates):fix missing info when fields was absent #14032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/db
cherry-pick kong-ee
outsinre
approved these changes
Dec 18, 2024
lhanjian
commented
Dec 18, 2024
| assert.equals("snis:required field missing:certificate", entities.flattened_errors[1].errors[1].message) | ||
| end) | ||
|
|
||
| it("flatten_errors1 when conflicting inputs", function() |
There was a problem hiding this comment.
Only add a test, not about errors.lua change
lhanjian
force-pushed
the
fix/missing-snis-missing-flattend-errors
branch
from
27a3f33 to
ab01f6c
Compare
chobits
requested changes
Dec 19, 2024
chobits
approved these changes
Dec 20, 2024
lhanjian
force-pushed
the
fix/missing-snis-missing-flattend-errors
branch
from
f66684b to
da087f8
Compare
flrgh
reviewed
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix FTI-6351