Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(clustering/rpc): add support for cert details #14050

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat(clustering/rpc): add support for cert details #14050

wants to merge 2 commits into from
+11 −12

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Dec 24, 2024 •
edited
Loading

Summary

KAG-6084
This PR follows #14046.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@github-actions github-actions bot added core/clustering cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Dec 24, 2024
@chronolaw chronolaw marked this pull request as ready for review December 24, 2024 13:20
dndx
dndx reviewed Dec 27, 2024
View reviewed changes
Copy link
Member

@dndx dndx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update the spec file as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dndx dndx dndx left review comments

@StarlightIbuki StarlightIbuki StarlightIbuki approved these changes

@chobits chobits Awaiting requested review from chobits

At least 2 approving reviews are required to merge this pull request.

Assignees

@chronolaw chronolaw

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/clustering size/S skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chronolaw @dndx @StarlightIbuki