Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runloop): skip router rebuilding if reconfigure is running #14056

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ADD-SP
Copy link
Contributor

@ADD-SP ADD-SP commented Dec 26, 2024

Summary

In rare cases, the rebuild timer will interrupt the reconfigure handler because of router was changed while rebuilding it, which results in an outdated plugin iterator and balancer.

It is hard to test this rare race condition.

Checklist

  • The Pull Request has tests
  • [N/A] A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • [N/A] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

KAG-6015

@github-actions github-actions bot added core/proxy cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Dec 26, 2024
@ADD-SP ADD-SP force-pushed the add_sp/refactor-rebuild-timers branch from a83dd4c to 0a5cdf2 Compare December 26, 2024 03:50
@ADD-SP ADD-SP force-pushed the add_sp/refactor-rebuild-timers branch from 0a5cdf2 to 5b70a5d Compare December 26, 2024 03:51
@ADD-SP ADD-SP marked this pull request as ready for review December 26, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/proxy size/S skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant