Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(router): load service with route.ws_id while building routers #14057

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chobits
Copy link
Contributor

@chobits chobits commented Dec 27, 2024

Summary

  1. From the perspective of more precise searching for services from select API, the route here already has a ws_id, so we should directly search for the service under the specific workspace
  2. LMDB has removed all the global query keys (see perf(lmdb): remove the key with global workspace id * #14028), if we select services without ws_id, it will search it through all the workspace, which has a performance issue.

Checklist

  • The Pull Request has tests - reuse original tests that could test router building
  • Skip changelog because we could reuse changelog/unreleased/kong/perf-lmdb-remove-global-query-key.yml
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix KAG-6087, KAG-5704

@github-actions github-actions bot added core/proxy cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/proxy size/S skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant