systemd scripts for xlxd #185
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianfrz
reviewed
Nov 4, 2023
| ExecStart=/xlxd/xlxd ${REFLECTOR} ${BIND_IP} ${AMBED_IP} | ||
| ExecStartPost=/bin/sh -c 'umask 022; pgrep xlxd > /var/log/xlxd.pid' | ||
| Restart=on-abnormal | ||
| PIDFile=/var/log/xlxd.pid |
There was a problem hiding this comment.
this is a bad place for a pid file - should belong somewhere under /var/run/xlxd.pid
Actually it would make sense if the service would be able to write that file by itself.
It would be even better if the service would be of type notify because then it can tell systemd when it is actually ready, but then you need to link against libsystemd. See sd_notify.
| After=network.target ambed.service | ||
|
|
||
| [Service] | ||
| Type=forking |
There was a problem hiding this comment.
for running in systemd, it would make more sense to compile it to not use the deamon mode and say simple. Then you can even use stdout / stderr for logging if you want.
| @@ -0,0 +1,10 @@ | |||
| # This is used by xlxd.service. Note this is shellcode sourced by xlxd.service | |||
There was a problem hiding this comment.
Suggested change
| # This is used by xlxd.service. Note this is shellcode sourced by xlxd.service | |
| # This is a systemd environment file loaded by xlxd.service |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
systemd-style service for xlxd