Skip to content

Commit

Permalink
🧹 Remove experimental flag from solana oft example (#1128)
Browse files Browse the repository at this point in the history
  • Loading branch information
St0rmBr3w authored Dec 12, 2024
1 parent d255778 commit e2cabc5
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion examples/oft-solana/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ cargo install --git https://github.com/coral-xyz/anchor --tag v0.29.0 anchor-cli
### Get the code

```bash
LZ_ENABLE_EXPERIMENTAL_SOLANA_OFT_EXAMPLE=1 npx create-lz-oapp@latest
LZ_ENABLE_SOLANA_OFT_EXAMPLE=1 npx create-lz-oapp@latest
```

### Installing Dependencies
Expand Down
2 changes: 1 addition & 1 deletion packages/create-lz-oapp/src/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ export const getExamples = (): Example[] => {
]
: []),
// The Solana OFT example is feature flagged for the time being
...(process.env.LZ_ENABLE_EXPERIMENTAL_SOLANA_OFT_EXAMPLE
...(process.env.LZ_ENABLE_SOLANA_OFT_EXAMPLE
? [
{
id: 'oft-solana',
Expand Down
8 changes: 4 additions & 4 deletions packages/create-lz-oapp/test/config.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,14 +40,14 @@ describe('config', () => {
examples.forEach((example) => expect(example).toMatchObject({ ref: 'ohhello' }))
})

it('should not include Solana OFT example if LZ_ENABLE_EXPERIMENTAL_SOLANA_OFT_EXAMPLE is empty', () => {
process.env.LZ_ENABLE_EXPERIMENTAL_SOLANA_OFT_EXAMPLE = ''
it('should not include Solana OFT example if LZ_ENABLE_SOLANA_OFT_EXAMPLE is empty', () => {
process.env.LZ_ENABLE_SOLANA_OFT_EXAMPLE = ''

expect(getExamples()).not.toContainEqual(expect.objectContaining({ id: 'oft-solana' }))
})

it('should include Solana OFT example if LZ_ENABLE_EXPERIMENTAL_SOLANA_OFT_EXAMPLE is defined', () => {
process.env.LZ_ENABLE_EXPERIMENTAL_SOLANA_OFT_EXAMPLE = 'yes'
it('should include Solana OFT example if LZ_ENABLE_SOLANA_OFT_EXAMPLE is defined', () => {
process.env.LZ_ENABLE_SOLANA_OFT_EXAMPLE = 'yes'

expect(getExamples()).toContainEqual(expect.objectContaining({ id: 'oft-solana' }))
})
Expand Down
6 changes: 3 additions & 3 deletions tests-user/tests/create-lz-oapp.bats
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ teardown() {
@test "should work with pnpm & oft solana example in CI mode" {
local DESTINATION="$PROJECTS_DIRECTORY/pnpm-oft-solana"

LZ_ENABLE_EXPERIMENTAL_SOLANA_OFT_EXAMPLE=1 npx --yes create-lz-oapp --ci --example oft-solana --destination $DESTINATION --package-manager pnpm
LZ_ENABLE_SOLANA_OFT_EXAMPLE=1 npx --yes create-lz-oapp --ci --example oft-solana --destination $DESTINATION --package-manager pnpm
cd "$DESTINATION"
pnpm compile
pnpm test
Expand Down Expand Up @@ -267,7 +267,7 @@ teardown() {
@test "should work with yarn & oft solana example in CI mode" {
local DESTINATION="$PROJECTS_DIRECTORY/yarn-oft-solana"

YARN_CACHE_FOLDER="/tmp/.yarn-cache-oft-solana" LZ_ENABLE_EXPERIMENTAL_SOLANA_OFT_EXAMPLE=1 npx --yes create-lz-oapp --ci --example oft-solana --destination $DESTINATION --package-manager yarn
YARN_CACHE_FOLDER="/tmp/.yarn-cache-oft-solana" LZ_ENABLE_SOLANA_OFT_EXAMPLE=1 npx --yes create-lz-oapp --ci --example oft-solana --destination $DESTINATION --package-manager yarn
cd "$DESTINATION"
yarn compile
yarn test
Expand Down Expand Up @@ -351,7 +351,7 @@ teardown() {
@test "should work with npm & oft solana example in CI mode" {
local DESTINATION="$PROJECTS_DIRECTORY/npm-oft-solana"

LZ_ENABLE_EXPERIMENTAL_SOLANA_OFT_EXAMPLE=1 npx --yes create-lz-oapp --ci --example oft-solana --destination $DESTINATION --package-manager npm
LZ_ENABLE_SOLANA_OFT_EXAMPLE=1 npx --yes create-lz-oapp --ci --example oft-solana --destination $DESTINATION --package-manager npm
cd "$DESTINATION"
npm run compile
npm run test
Expand Down
2 changes: 1 addition & 1 deletion turbo.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"LZ_ENABLE_EXPERIMENTAL_PARALLEL_EXECUTION",
"LZ_ENABLE_EXPERIMENTAL_RETRY",
"LZ_ENABLE_EXPERIMENTAL_SIMULATION",
"LZ_ENABLE_EXPERIMENTAL_SOLANA_OFT_EXAMPLE",
"LZ_ENABLE_SOLANA_OFT_EXAMPLE",
"LZ_ENABLE_READ_EXAMPLE",
"LZ_ENABLE_ZKSOLC_EXAMPLE",
"LZ_ENABLE_NATIVE_EXAMPLE",
Expand Down

0 comments on commit e2cabc5

Please sign in to comment.