Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎁 CLI flow [2/N] #13

Merged
merged 4 commits into from
Nov 15, 2023
Merged

🎁 CLI flow [2/N] #13

merged 4 commits into from
Nov 15, 2023

Conversation

janjakubnanista
Copy link
Contributor

@janjakubnanista janjakubnanista commented Nov 15, 2023 •
edited
Loading

In this PR

  • Add two examples to the CLI
  • Add cloning & installation flow. The installation now fails on an NPM error (the DX still to be improved) coming from the example itself
CLI.mov

sirarthurmoney
sirarthurmoney approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@sirarthurmoney sirarthurmoney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@TRileySchwarz TRileySchwarz merged commit 65c2868 into main Nov 15, 2023
1 check passed
@TRileySchwarz TRileySchwarz deleted the examples-v2 branch November 15, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirarthurmoney sirarthurmoney sirarthurmoney approved these changes

@TRileySchwarz TRileySchwarz TRileySchwarz approved these changes

@0xIryna 0xIryna Awaiting requested review from 0xIryna

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@janjakubnanista @TRileySchwarz @sirarthurmoney