Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poc(lld): πŸ”’ ASAR integrity check #8748

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

thesan
Copy link
Contributor

@thesan thesan commented Dec 20, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

This draft attempts to enable the ASAR integrity check and upgrade electron builder to v25 to enable it on Windows too.
So far:

  • tiny-secp256k1 doesn't build with electron@32+ so the version of electron was downgraded to 31.
  • electron-app-universal-protocol-client also doesn't build so it was temporary removed (as it's barely used).
  • The build goes through but the app crashes with: "Termination Reason: Namespace CODESIGNING, Code 2 Invalid Page". However this might be the normal behaviour (maybe due to multiple versions of the app or maybe because the app is not signed).

More details in the tech research

πŸŽ₯ Demo:

On MacOS:

withCheck.mov

On Windows:

WinASARCheck.mp4

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Dec 20, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2025 10:22am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2025 10:22am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2025 10:22am
web-tools ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2025 10:22am

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Dec 20, 2024
Copy link

github-actions bot commented Jan 5, 2025

There as been no activity on this PR for the last 14 days. Please consider closing this PR.

@github-actions github-actions bot added the Stale label Jan 5, 2025
@thesan thesan force-pushed the poc/asar-integrity-check branch from e58b481 to e2b45f6 Compare January 8, 2025 08:58
@thesan thesan force-pushed the poc/asar-integrity-check branch from e2b45f6 to 47a70f4 Compare January 9, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant