Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/improve-aptos-ledger-account-testsTest/testing sign transaction method #8838

Conversation

may01
Copy link
Contributor

@may01 may01 commented Jan 7, 2025

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Proposal for test fix

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@may01 may01 requested a review from a team as a code owner January 7, 2025 15:35
Copy link

vercel bot commented Jan 7, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools ❌ Failed (Inspect) Jan 7, 2025 3:35pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Jan 7, 2025 3:35pm
native-ui-storybook ⬜️ Ignored (Inspect) Jan 7, 2025 3:35pm
react-ui-storybook ⬜️ Ignored (Inspect) Jan 7, 2025 3:35pm

@live-github-bot live-github-bot bot added the common Has changes in live-common label Jan 7, 2025
@joaoccmartins joaoccmartins merged commit 916f694 into feat/improve-aptos-ledger-account-tests Jan 7, 2025
30 of 55 checks passed
@joaoccmartins joaoccmartins deleted the test/Testing-signTransaction-method branch January 7, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants