Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhauled the system to be flexible enough to take local pro files or the site #69

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

daemedeor
Copy link

Due to 6.2.0 release of Font Awesome, they overhauled the naming system that was in use and deviates a lot from the current cheatsheet version of the site. Since the enums are missing a lot from the pro versions and can no longer support the amount of Icons, I decided to overhaul the system instead. I know there are a lot of files changed but there wasn't a simple way to preserve the formatting of forced strings due to the complexity of the new structure.

I was missing a lot of icons between Feb 2022 and Sept 2022 version of Font Awesome, so this brings it parity. This also allows for people to feed their own version of FA in order to generate font files outside of the runs of this repo (which are few and far between).

@daemedeor
Copy link
Author

Also note: this includes #67 as part of the request to merge. Would appreciate a look at it when you get a chance!

@klousy92
Copy link

You didn't add CaseIterable to the enums right?

So using the FontAwesome unicodes is still not possible with your changes?
Like this:

Awesome.Regular(rawValue: "\u{f007}")?.image

@daemedeor
Copy link
Author

@klousy92 I had difficulties when I made it CaseIterable but I can try to make it work again. While you couldn't use Awesome.Regular(rawValue: "") unfotunately. But I did make a unicode exnteion in unicodeString OR you can do do Awesome.Regular.withKey(_) to find it that way

@jordanpwood
Copy link

@daemedeor, I tried forking off your repo and using the generator script to update to Awesome 6.4.0, but I don't know how to feed my local Pro files into the generator script. Can you give some guidance on how to do that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants