Skip to content

Commit

Permalink
Prepare for CRAN submission
Browse files Browse the repository at this point in the history
  • Loading branch information
LudvigOlsen committed May 28, 2020
1 parent e4d1f52 commit c31f199
Show file tree
Hide file tree
Showing 6 changed files with 15 additions and 12 deletions.
5 changes: 5 additions & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,11 @@ matrix:
- sudo add-apt-repository -y ppa:cran/imagemagick
- sudo apt-get update
- sudo apt-get install -y libmagick++-dev
- r: 3.5.0
before_install:
- sudo add-apt-repository -y ppa:cran/imagemagick
- sudo apt-get update
- sudo apt-get install -y libmagick++-dev

# The addon solution to installing imagemagick didn't work, so we install it
# manually on every ubuntu machine. Might work if we use later ubuntu distributions.
Expand Down
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: cvms
Title: Cross-Validation for Model Selection
Version: 1.0.1.9000
Version: 1.0.2
Authors@R:
c(person(given = "Ludvig Renbo",
family = "Olsen",
Expand Down
4 changes: 3 additions & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@

# cvms 1.0.1.9000
# cvms 1.0.2

* Compatibility with `dplyr` version `1.0.0`. NOTE: this version of `dplyr` slows down some functions in `cvms` significantly, why it might be beneficial not to update before version `1.1.0`, which is supposed to tackle this problem.

# cvms 1.0.1

Expand Down
12 changes: 4 additions & 8 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,17 +1,13 @@
## Test environments
* local OS X install, R 3.6.1
* ubuntu 16.04.6 (on travis-ci), R 3.5.3, 3.6.1 and devel
* ubuntu 16.04.6 (on travis-ci), R 3.6.3, 4.0.0 and devel
* win-builder

## R CMD check results
There were no ERRORs or WARNINGs. There was 1 NOTE when 'rsvg' was not installed (as expected).
There were no ERRORs or WARNINGs. There was 1 NOTE when `rsvg` was not installed (as expected).

## Downstream dependencies
There are currently no downstream dependencies.


## Fixes for 1.0.0 errors
* Moved ggimage and rsvg to Suggests. rsvg is not used *directly* by cvms but by ggimage. I added checks to make sure ggimage isn't called when either ggimage or rsvg isn't installed. I also skip tests when it is not available.
* Fixed the failing unit test by improving the input checks in evaluate().
* Stripped numbers from error messages in unit tests that fail on platforms without support for long doubles. The specific numbers are not that important in those tests.
* Skips a lot of the unit tests to stay within time limits. This seems an unfortunate step but I've tried to maintain tests of the basic building blocks. All the tests will still be tested locally and on Travis CI.
## Release notes
Please be aware, that the performance drop in the upcoming `dplyr v1.0.0` for `summarize()` and similar functions seem to have a big impact on `cvms`, and that this might affect the testing time significantly. Given that the `tidyverse` folks intend to fix this in `v1.1.0` (as I understand it), I will not be skipping more unittests on CRAN unless specifically requested by CRAN.
4 changes: 2 additions & 2 deletions revdep/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,13 @@
|collate |en_US.UTF-8 |
|ctype |en_US.UTF-8 |
|tz |Europe/Copenhagen |
|date |2020-04-13 |
|date |2020-05-28 |

# Dependencies

|package |old |new |Δ |
|:-------|:-----|:-----|:--|
|cvms |0.3.2 |1.0.0 |* |
|cvms |1.0.1 |1.0.2 |* |

# Revdeps

Binary file added revdep/data.sqlite
Binary file not shown.

0 comments on commit c31f199

Please sign in to comment.