-
Notifications
You must be signed in to change notification settings - Fork 7
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
e4d1f52
commit c31f199
Showing
6 changed files
with
15 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,17 +1,13 @@ | ||
## Test environments | ||
* local OS X install, R 3.6.1 | ||
* ubuntu 16.04.6 (on travis-ci), R 3.5.3, 3.6.1 and devel | ||
* ubuntu 16.04.6 (on travis-ci), R 3.6.3, 4.0.0 and devel | ||
* win-builder | ||
|
||
## R CMD check results | ||
There were no ERRORs or WARNINGs. There was 1 NOTE when 'rsvg' was not installed (as expected). | ||
There were no ERRORs or WARNINGs. There was 1 NOTE when `rsvg` was not installed (as expected). | ||
|
||
## Downstream dependencies | ||
There are currently no downstream dependencies. | ||
|
||
|
||
## Fixes for 1.0.0 errors | ||
* Moved ggimage and rsvg to Suggests. rsvg is not used *directly* by cvms but by ggimage. I added checks to make sure ggimage isn't called when either ggimage or rsvg isn't installed. I also skip tests when it is not available. | ||
* Fixed the failing unit test by improving the input checks in evaluate(). | ||
* Stripped numbers from error messages in unit tests that fail on platforms without support for long doubles. The specific numbers are not that important in those tests. | ||
* Skips a lot of the unit tests to stay within time limits. This seems an unfortunate step but I've tried to maintain tests of the basic building blocks. All the tests will still be tested locally and on Travis CI. | ||
## Release notes | ||
Please be aware, that the performance drop in the upcoming `dplyr v1.0.0` for `summarize()` and similar functions seem to have a big impact on `cvms`, and that this might affect the testing time significantly. Given that the `tidyverse` folks intend to fix this in `v1.1.0` (as I understand it), I will not be skipping more unittests on CRAN unless specifically requested by CRAN. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.