Skip to content

Commit

Permalink
Change python version req from 3.11 to 3.8.
Browse files Browse the repository at this point in the history
  • Loading branch information
jzohrab committed Nov 7, 2023
1 parent f31ceee commit cb5ace9
Show file tree
Hide file tree
Showing 7 changed files with 14 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:

- uses: actions/setup-python@v4
with:
python-version: '3.11'
python-version: '3.8'
cache: 'pip' # caching pip dependencies

- run: pip install -r requirements.txt
Expand Down
5 changes: 4 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,12 @@ Python 3
# Install

```
python3 -m venv .venv
python3.8 -m venv .venv
source .venv/bin/activate
# verify version
python --version
pip install -r requirements.txt
deactivate
Expand Down
2 changes: 1 addition & 1 deletion README_PyPi.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Lute v3 is a rewrite of the original Lute PHP application in Python and Flask.

## Requirements

Python 3.11+
Python 3.8+

## Install

Expand Down
2 changes: 1 addition & 1 deletion lute/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@
"""

# TODO release: fix version number
__version__ = "0.0.1.post6"
__version__ = "0.0.1.post7"
5 changes: 2 additions & 3 deletions lute/utils/data_tables.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
Helper methods to get data for datatables display.
"""

from typing import Any
import re
from sqlalchemy.sql import text
from lute.parse.registry import supported_parser_types
Expand Down Expand Up @@ -51,7 +50,7 @@ class DataTablesFlaskParamParser:
"""

@staticmethod
def _parse_order(request_params: dict[str, Any]) -> list:
def _parse_order(request_params):
"""Parse the order[index][*] parameters."""
order = []
order_re = re.compile(r'order\[(.*?)]\[column]')
Expand All @@ -66,7 +65,7 @@ def _parse_order(request_params: dict[str, Any]) -> list:
return order

@staticmethod
def _parse_columns(request_params: dict[str, Any]) -> list:
def _parse_columns(request_params):
"""Parse the column[index][*] parameters."""
columns = []
# Extract only the keys of type columns[i][data] from the params
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ name = "lute3"
dynamic = ['version']

description = "Learning Using Texts"
requires-python = ">=3.11"
requires-python = ">=3.8"
authors = [
{name = "Jeff Zohrab", email = "jzohrab@gmail.com"}
]
Expand Down
4 changes: 4 additions & 0 deletions requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,15 @@ click==8.1.7
coverage==7.3.1
dill==0.3.7
docutils==0.20.1
exceptiongroup==1.1.3
Flask==2.3.3
Flask-SQLAlchemy==3.1.1
Flask-WTF==1.2.1
flit==3.9.0
flit_core==3.9.0
h11==0.14.0
idna==3.4
importlib-metadata==6.8.0
iniconfig==2.0.0
invoke==2.2.0
isort==5.12.0
Expand Down Expand Up @@ -49,6 +51,7 @@ soupsieve==2.5
splinter==0.19.0
SQLAlchemy==2.0.21
toml==0.10.2
tomli==2.0.1
tomli_w==1.0.0
tomlkit==0.12.1
trio==0.22.2
Expand All @@ -60,3 +63,4 @@ Werkzeug==2.3.7
wrapt==1.15.0
wsproto==1.2.0
WTForms==3.0.1
zipp==3.17.0

0 comments on commit cb5ace9

Please sign in to comment.