Skip to content

Commit

Permalink
Merge pull request #176 from avik-pal/ap/ambiguous
Browse files Browse the repository at this point in the history
`setup` only on AbstractRules
  • Loading branch information
avik-pal authored Oct 14, 2022
2 parents 9a34140 + fe19182 commit 8441dc7
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "Lux"
uuid = "b2108857-7c20-44ae-9111-449ecde12c47"
authors = ["Avik Pal <avikpal@mit.edu> and contributors"]
version = "0.4.28"
version = "0.4.29"

[deps]
Adapt = "79e6a3ab-5dfb-504d-930d-738a2a938a0e"
Expand Down
2 changes: 1 addition & 1 deletion src/utils.jl
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ function Functors.functor(::Type{<:ComponentArray}, c)
ComponentArray
end

Optimisers.setup(opt, ps::ComponentArray) = Optimisers.setup(opt, getdata(ps))
Optimisers.setup(opt::AbstractRule, ps::ComponentArray) = Optimisers.setup(opt, getdata(ps))

function Optimisers.update(tree, ps::ComponentArray, gs::ComponentArray)
tree, ps_new = Optimisers.update(tree, getdata(ps), getdata(gs))
Expand Down

2 comments on commit 8441dc7

@avik-pal
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/70302

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.4.29 -m "<description of version>" 8441dc7c7165c4c9c27aa205ad13d543c6fe5123
git push origin v0.4.29

Please sign in to comment.