This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
handle bitstypes and wrapped arrays in isleaf #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ready to go |
avik-pal
reviewed
Oct 20, 2024
2 tasks
|
merge? |
|
Cuda GPU CIs are stalled. Waiting for that to be unblocked
…On Mon, 21 Oct, 2024, 19:15 Carlo Lucibello, ***@***.***> wrote:
merge?
—
Reply to this email directly, view it on GitHub
<#88 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHJF57XYP5UJ52LHO75H2P3Z4WDK3AVCNFSM6AAAAABQIIT5B6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRXHEYDKNRWGA>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting over some desirable behavior from Flux.
Make
MLDataDevices.isleaf(x::AbstractArray{T}) = truewhenTis a bitstype. Also, make sure wrapped arrays are handled correctly as discussed in FluxML/Flux.jl#2432 and FluxML/Flux.jl#2436