-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fmt] Guesser #4851
[fmt] Guesser #4851
Conversation
I fixed a few nasty trailing commas, but otherwise LGTM. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4851 +/- ##
===========================================
+ Coverage 86.06% 93.65% +7.59%
===========================================
Files 177 177
Lines 21779 21779
Branches 3064 3064
===========================================
+ Hits 18744 20398 +1654
+ Misses 2597 929 -1668
- Partials 438 452 +14 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blanket LGTM — please merge when you're happy with it @RMeli
🎄 🎁
Hello @RMeli! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
📚 Documentation preview 📚: https://mdanalysis--4851.org.readthedocs.build/en/4851/