Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fmt] Guesser #4851

Merged
merged 3 commits into from
Dec 24, 2024
Merged

[fmt] Guesser #4851

merged 3 commits into from
Dec 24, 2024

Conversation

RMeli
Copy link
Member

@RMeli RMeli commented Dec 20, 2024

@RMeli
Copy link
Member Author

RMeli commented Dec 20, 2024

I fixed a few nasty trailing commas, but otherwise LGTM.

@RMeli RMeli requested review from IAlibay and marinegor December 20, 2024 21:16
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.65%. Comparing base (f855022) to head (1dc6afe).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4851      +/-   ##
===========================================
+ Coverage    86.06%   93.65%   +7.59%     
===========================================
  Files          177      177              
  Lines        21779    21779              
  Branches      3064     3064              
===========================================
+ Hits         18744    20398    +1654     
+ Misses        2597      929    -1668     
- Partials       438      452      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RMeli RMeli enabled auto-merge (squash) December 21, 2024 13:48
Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blanket LGTM — please merge when you're happy with it @RMeli

🎄 🎁

@pep8speaks
Copy link

Hello @RMeli! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 441:21: W503 line break before binary operator
Line 444:21: W503 line break before binary operator
Line 445:21: W503 line break before binary operator

@RMeli RMeli merged commit a10e23e into MDAnalysis:develop Dec 24, 2024
14 of 22 checks passed
@RMeli RMeli deleted the fmt-guesser branch December 24, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants