Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fmt] Selections #4861

Merged
merged 1 commit into from
Dec 24, 2024
Merged

[fmt] Selections #4861

merged 1 commit into from
Dec 24, 2024

Conversation

RMeli
Copy link
Member

@RMeli RMeli commented Dec 22, 2024

Easy one, already good to go.


📚 Documentation preview 📚: https://mdanalysis--4861.org.readthedocs.build/en/4861/

@RMeli RMeli self-assigned this Dec 22, 2024
@RMeli RMeli requested a review from marinegor December 22, 2024 22:16
@pep8speaks
Copy link

Hello @RMeli! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 132:12: E713 test for membership should be 'not in'
Line 211:41: E203 whitespace before ':'

Copy link

codecov bot commented Dec 22, 2024

Codecov Report

Attention: Patch coverage is 92.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.63%. Comparing base (9110a6e) to head (1ee857e).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
package/MDAnalysis/selections/base.py 85.71% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4861      +/-   ##
===========================================
- Coverage    93.65%   93.63%   -0.03%     
===========================================
  Files          177      189      +12     
  Lines        21779    22845    +1066     
  Branches      3064     3064              
===========================================
+ Hits         20398    21391     +993     
- Misses         929     1002      +73     
  Partials       452      452              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blanket LGTM — please merge when you're happy with it @RMeli

🎄 🎁

@RMeli RMeli merged commit 55cce24 into MDAnalysis:develop Dec 24, 2024
24 of 26 checks passed
@RMeli RMeli deleted the fmt-selections branch December 24, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants