-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rdma #606
Add rdma #606
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adds flag for rdma for testing and passes to ./mfc sh run
This PR indeed does this but does not do anything differently within the ./mfc.sh run
environment. It should ensure the RDMA_MPI = 'T'
in the generated case.py
file.
The changes in the To clarify, when you
So there is no need to have the |
Where in the project/program is the case.py file generated? From my understanding each case.py contains the configurations for its respective test/example and is manually written. I understand the rest of how the test and run features work as well as how the arguments including the case file are passed. |
This is where we declare the parser of the case.py files used for testing: MFC/toolchain/mfc/test/case.py Line 182 in 0c345ea
--rdma flag and make it set rdma_mpi={'T' if rdma else 'F'} in the case dictionary printed by the case file.
|
got it thanks, i missed that when i was going through the files |
Description
Please include a summary of the changes and the related issue(s) if they exist.
Please also include relevant motivation and context.
Fixes #598
Adds flag for rdma for testing and passes to ./mfc sh run
Compiles on macbook and runs tests but needs to be tested on gpu with rdma, may have errors