-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lagrangian subgrid bubble model #749
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #749 +/- ##
==========================================
- Coverage 44.72% 43.80% -0.92%
==========================================
Files 62 65 +3
Lines 17555 19011 +1456
Branches 2044 2313 +269
==========================================
+ Hits 7851 8328 +477
- Misses 8439 9276 +837
- Partials 1265 1407 +142 ☔ View full report in Codecov by Sentry. |
Thanks! This is failing some tests, like Frontier w/ CCE18 and AMD GPUs (MI250X). I'm not sure if you have access to this machine to debug yourself @dgvacarevelo |
@sbryngelson No, I don't have access to Frontier. I implemented the GPU acceleration using DELTA through ACCESS resources. |
Requesting code review from @anshgupta1234 @wilfonba @haochey @ChrisZYJ and Frontier help from @wilfonba and @anandrdbz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice and well put together PR @dgvacarevelo! I made a few minor comments, but overall every thing looks good. I'll look into the Frontier issues when I get a chance. Hopefully this weekend.
Description
The Euler-Lagrange model for sub-grid bubble dynamics is based on the volume-averaged equations
of motion to describe the dynamics of a mixture of dispersed bubbles and a compressible liquid.
Type of change
Scope
If you cannot check the above box, please split your PR into multiple PRs that each have a common goal.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration
A cuboidal bubble cloud interacts with a sinusoidal planar wave. This case is included as an example case (examples/3D_lag_bubbles_bubblescreen). The pressure at the center of the cloud is measured and compared, as follows.
A single bubble of 8 micrometers encounters a sinusoidal planar wave. This case is also included as an example case (examples/3D_lag_bubbles_shbubcollapse). The radius evolution of the bubble is compared with the experiment reported by (Ohl et. al, 1999) (https://doi.org/10.1098/rsta.1999.0327).
Test Configuration:
Checklist
docs/
)examples/
that demonstrate my new feature performing as expected.They run to completion and demonstrate "interesting physics"
./mfc.sh format
before committing my codeIf your code changes any code source files (anything in
src/simulation
)To make sure the code is performing as expected on GPU devices, I have:
nvtx
ranges so that they can be identified in profiles./mfc.sh run XXXX --gpu -t simulation --nsys
, and have attached the output file (.nsys-rep
) and plain text results to this PR./mfc.sh run XXXX --gpu -t simulation --omniperf
, and have attached the output file and plain text results to this PR.