Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix hypoelastic instability" #776

Merged
merged 4 commits into from
Dec 27, 2024

Conversation

sbryngelson
Copy link
Member

Reverts #773

@sbryngelson sbryngelson requested review from ChrisZYJ and removed request for henryleberre December 26, 2024 14:37
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 31.03448% with 40 lines in your changes missing coverage. Please review.

Project coverage is 43.79%. Comparing base (5d8c07c) to head (03aad5b).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/simulation/m_hypoelastic.fpp 29.82% 33 Missing and 7 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #776      +/-   ##
==========================================
+ Coverage   43.72%   43.79%   +0.07%     
==========================================
  Files          65       65              
  Lines       19053    19056       +3     
  Branches     2319     2326       +7     
==========================================
+ Hits         8331     8346      +15     
+ Misses       9320     9302      -18     
- Partials     1402     1408       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

use m_global_parameters !< Definitions of the global parameters

use m_finite_differences
use m_helper
use m_mpi_proxy !< Message passing interface (MPI) module proxy
Copy link
Contributor

@ChrisZYJ ChrisZYJ Dec 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we please remove the use m_mpi_proxy line? I think it wasn't present in the previous version.

@ChrisZYJ
Copy link
Contributor

Yes this is exactly what I meant. I made one comment but don't think it matters. Really sorry for the trouble!

@sbryngelson sbryngelson merged commit d667ea7 into master Dec 27, 2024
53 checks passed
@sbryngelson sbryngelson deleted the revert-773-fix_hypo_instability branch December 27, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants