chore: remove aggregated computation #651
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b11b449.
vjousse
changed the base branch from
master
to
chore/dont-use-django-to-get-processes
We don't use it for now, it will be part of another PR
vjousse
force-pushed
the
chore/remove-aggregated-computation
branch
from
17adb71 to
b75a554
Compare
vjousse
force-pushed
the
chore/dont-use-django-to-get-processes
branch
from
a87d2f3 to
f6e9d5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Problem
We are currently using 2 different files to serve the same processes with detailed impacts and without. It requires some post processing and duplicated code/files to just set some values to 0.
🍰 Solution
As we are now loading in memory the detailed impacts file at server load, we can easily serve the undetailed version by parsing the JSON object and creating a copy with the detailed impacts set at zero.
🏝️ How to test
It should be an idempotent change. The app and the API should still work as expected when logged in and when not logged in.