vulnerability fix using htmlspecialchars - issue #32

MaestroError · Feb 9, 2024 · 7d523fb · 7d523fb
1 parent 1d307ee
commit 7d523fb
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/HeicToJpg.php b/src/HeicToJpg.php
@@ -185,6 +185,7 @@ public function checkOS($forceArm = false) {
      * @return void
      */
     protected function processImage(string $source) {
+        $source = htmlspecialchars($source);
         $this->heic = $source;
         $newFileName = $source . "-" . uniqid(rand(), true);
         $exeName = $this->exeName;
@@ -316,7 +317,7 @@ public static function convert(string $source, string $converterPath = "", $forc
         return (new self)
             ->checkOS($forceArm)
             ->setConverterLocation($converterPath)
-            ->convertImage(htmlspecialchars($source));
+            ->convertImage($source);
     }
 
     public static function convertOnMac(string $source, string $arch = "amd64", string $converterPath = "")

diff --git a/tests/Unit/images/;whoami;#.heic b/tests/Unit/images/;whoami;#.heic