Tech/3483/integrate kotter #3609
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phanlezz
force-pushed
the
tech/3483/integrate-kotter
branch
from
6282905 to
11807b5
Compare
|
I rebased the changes on-top of the current main branch. |
14 tasks
|
|
This is blocked by flaky tests that we think are caused by a bug in kotters testing library (we created an issue for that: varabyte/kotter#114) |
Class is no longer needed as all functions extend the Session class from Kotter and are applicable in the correct scope
Still a lot of todos that need to be closed and comments that need to be implemented, as well as finding a solution for the session problem
…3483) Also added defaultCallback to reduce tests getting stuck on dropped input for debugging purposes. Swapped to inmemory versions of kotter press and type functions
phanlezz
force-pushed
the
tech/3483/integrate-kotter
branch
from
efb4e7e to
5abd1e1
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebuild functionality of the no longer supported KotlinInquirer using Kotter
Issue: #3483
Description
Use the Kotter library to rebuild the functionality of the KolinInquirer Library. It is currently used for the interactive CLI interface but is no longer supported.
Using our own questions built with kotter gives us more control over the interactive questions and allows for features like auto completion.
This also integrates the new kotter methods into the StructureModifier.
Definition of Done
A PR is only ready for merge once all the following acceptance criteria are fulfilled:
Screenshots or gifs