Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect vsphere tags and categories #626

Merged
merged 9 commits into from
Sep 17, 2020

Conversation

agrare
Copy link
Member

@agrare agrare commented Sep 14, 2020

Depends: ManageIQ/manageiq#20554
UI: ManageIQ/manageiq-ui-classic#7318

Fixes #539

Categories:
Screenshot from 2020-09-16 13-03-45

Tags:
Screenshot from 2020-09-16 13-04-45

Assigning tags to objects:
Screenshot from 2020-09-16 13-06-01

VM summary screen showing labels:
Screenshot from 2020-09-17 11-09-30

@agrare agrare requested a review from Fryguy as a code owner September 14, 2020 23:36
@agrare agrare changed the title Collect vsphere tags and categories [WIP] Collect vsphere tags and categories Sep 14, 2020
@miq-bot miq-bot added the wip label Sep 14, 2020
@agrare agrare force-pushed the collect_vsphere_tags branch 2 times, most recently from 5910c22 to e58ced6 Compare September 15, 2020 00:09
@agrare agrare force-pushed the collect_vsphere_tags branch from cdbbe72 to 47f97bd Compare September 15, 2020 13:47
@agrare agrare force-pushed the collect_vsphere_tags branch from 47f97bd to 2dde509 Compare September 15, 2020 19:08
@agrare agrare force-pushed the collect_vsphere_tags branch 7 times, most recently from 8f6a80c to 740e16d Compare September 17, 2020 14:17
@agrare agrare changed the title [WIP] Collect vsphere tags and categories Collect vsphere tags and categories Sep 17, 2020
@agrare agrare removed the wip label Sep 17, 2020
@gtanzillo gtanzillo self-assigned this Sep 17, 2020
@agrare agrare force-pushed the collect_vsphere_tags branch from 740e16d to dcba19f Compare September 17, 2020 18:35
@miq-bot
Copy link
Member

miq-bot commented Sep 17, 2020

Checked commits agrare/manageiq-providers-vmware@d3ef4d9~...dcba19f with ruby 2.6.3, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
6 files checked, 0 offenses detected
Everything looks fine. ⭐

@gtanzillo gtanzillo merged commit 8894744 into ManageIQ:master Sep 17, 2020
@agrare agrare deleted the collect_vsphere_tags branch September 17, 2020 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Present VMware Tags as labels
5 participants