Add plugin global settings for ExampleViewOpenGl plugin #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add default point size action to the global settings action Initialize point size from global settings default point size Simplified the SettingsAction (derive from group action instead of WidgetAction) Correctly connect lambdas to ExampleViewGLPlugin::updatePlot() in SettingsAction Add ExampleViewGLPlugin SettingsAction as a docking widget
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new features and addresses some issues:
SettingsActionby deriving fromGroupAction, thereby eliminating the need to create a widget manually