-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renaming of HDPS to ManiVault #395
Conversation
In the conanfile.py the HDPS_INSTALL_DIR should change to MV_INSTALL_DIR. Also in the conan file the package name for the artifactory is still hdps-core. Leave this for the moment. I'll change this to mv-core in a separate commit as this needs to be coordinated with changes to the rulesupport login (that is used to sync feature branches of plugins with the corresponding core). |
This is also something to keep in mind: Every plugin uses As far as I know the generated |
@alxvth Indeed, I agree targets and config should be used in future (see my PR description), but I have separated this change out as it is not absolutely required for the release and after discussion we'd like to limit such changes as much as possible. |
Yes, I understand. My proposal would just be to comment out or delete
for the time being since their output is not used anywhere, doesn't work and might just confuse developers. (If in this PR or another I don't mind.) |
1b169fc
to
92c7d55
Compare
8be120b
to
98e5546
Compare
98e5546
to
f4616f2
Compare
In this pull request:
This pull request first included an overhaul of the CMake building to use config files, which allow us to link to manivault using find_package(ManiVault), target_link_libraries(ManiVault::Core). Instead of the 10 lines of code to establish the proper library name on every platform. Added benefit being the ability to include defines, see namespaces section. After discussion, I have separated out the config file update for post-release.
Namespaces: Unfortunately without a config file, there is no nice way to embed a #define mv hdps in the public library. The core namespace will stay hdps temporarily. For now, we can iteratively add target_compile_definitions(${PROJECT} PRIVATE mv=hdps) to every plugin cmake, and find/replace its namespace to mv. The define will transform each occurance of mv to hdps.
In this way, no plugin is automatically broken by merging this pull request, and when we finish with replacing their use of the hdps namespace, we can simply find/replace hpds to mv in the core, and remove the target_compile_definitions from all plugin cmakes.