-
-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(sdk): always send RPC requests via network and deeplink #1181
Conversation
- Moved RPC method tracking logic to ensure it is executed before sending analytics. - Enhanced logging for the RPC method tracker to include detailed information about the tracked methods and data. - Removed redundant console warnings to clean up the code and improve readability.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1181 +/- ##
==========================================
- Coverage 74.14% 74.13% -0.02%
==========================================
Files 181 181
Lines 4305 4299 -6
Branches 1056 1053 -3
==========================================
- Hits 3192 3187 -5
+ Misses 1113 1112 -1 ☔ View full report in Codecov by Sentry. |
• Remove conditional analytics sending • Always send RPC requests via network • Add debug logging for triggeredInstaller state • Remove redundant RPC method tracking
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
First request analytics are coming through after connecting. Screen.Recording.2024-12-19.at.10.02.58.AM.mov |
Description
This PR simplifies the RPC message handling strategy by sending requests through both network and deeplink channels simultaneously, allowing the wallet to process whichever arrives first. This approach eliminates edge cases and improves reliability while maintaining backward compatibility.
Technical Details
Migration
No migration steps required. This is a transparent change that maintains backward compatibility.
Related: