-
-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: adds a unique id to RPC events for extension #996
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we can use this approach.
After thinking it through, sending the address ( even hashed ) to then store and use in our analytics is not something we can do as pertains to Privacy.
There has been a lot of work related to MetaMetricsID, that down the line we can use, but as a short term solution we should just generate a random ID.
So if we can generate and store a randomID on the client browser to use for the sdk_analytics.
eef8b44
to
51cf5b9
Compare
51cf5b9
to
ecd3e74
Compare
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #996 +/- ##
==========================================
+ Coverage 80.57% 80.69% +0.11%
==========================================
Files 177 178 +1
Lines 4001 4035 +34
Branches 993 1001 +8
==========================================
+ Hits 3224 3256 +32
- Misses 777 779 +2 ☔ View full report in Codecov by Sentry. |
packages/sdk/src/provider/extensionProviderHelpers/handleUuid.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
#1000) fix: sets the `from` to `mobile` when connected via MM mobile in-app browser
b4e0bb8
packages/sdk/src/provider/extensionProviderHelpers/handleUuid.ts
Outdated
Show resolved
Hide resolved
packages/sdk/src/provider/extensionProviderHelpers/handleBatchMethod.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The functionality of how we distinguish what the "from" value is critical.
I do not see any reason for us to re-implement that if we already have a method exposed by the SDK that can get the connected "from" in a more detailed manner.
When on a desktop browser, the user connects with the MM mobile app via QRCode, the Video: |
@omridan159 could you take a look over the code here, and approve if everything is good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved to get into release but might need to adjust logic to simplify later.
Quality Gate passedIssues Measures |
Explanation
Fixes the unique id (
5a374dcd2e5eb762b527af3a5bab6072a4d24493
- SHA1 ofsdk
string) for all analytics events coming from extension. It adds a UUID that is stored in the localStorage with a key that is the base64 of theurl
andname
coming from the dapp metadata.It also includes #1000 setting the
from
tomobile
for RPC calls events when a dapp is opened in the MM mobile in-app browser.Testing
5a374dcd2e5eb762b527af3a5bab6072a4d24493
from
is set tomobile
and notextension
References
Checklist