Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/445 use appropriate cta #320

Closed
wants to merge 7 commits into from
Closed

Feature/445 use appropriate cta #320

wants to merge 7 commits into from

Conversation

kevin-chassagne
Copy link
Contributor

useMetamaskDetect hook

Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@metamask/sdk 0.14.1 environment +71 62.4 MB metamaskbot

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Issue Package Version Note Source
Deprecated webextension-polyfill-ts 0.25.0
  • Reason: This project has moved to @types/webextension-polyfill
Network access cross-fetch 3.1.6
Network access cross-fetch 4.0.0
New author extension-port-stream 2.1.1
New author @metamask/onboarding 1.0.1
New author @metamask/safe-event-emitter 3.0.0
New author find-root 1.1.0
New author void-elements 3.1.0
New author @metamask/object-multiplex 1.3.0
No README @emotion/serialize 1.1.2
No README @emotion/utils 1.2.1

Next steps

What is a deprecated package?

The maintainer of the package marked it as deprecated. This could indicate that a single version should not be used, or that the package is no longer maintained and any new vulnerabilities will not be fixed.

Research the state of the package and determine if there are non-deprecated versions that can be used, or if it should be replaced with a new, supported solution.

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

Why are READMEs important?

Package does not have a README. This may indicate a failed publish or a low quality package.

Add a README to to the package and publish a new version.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore @emotion/serialize@1.1.2
  • @SocketSecurity ignore @emotion/utils@1.2.1
  • @SocketSecurity ignore extension-port-stream@2.1.1
  • @SocketSecurity ignore @metamask/onboarding@1.0.1
  • @SocketSecurity ignore @metamask/safe-event-emitter@3.0.0
  • @SocketSecurity ignore find-root@1.1.0
  • @SocketSecurity ignore void-elements@3.1.0
  • @SocketSecurity ignore @metamask/object-multiplex@1.3.0
  • @SocketSecurity ignore webextension-polyfill-ts@0.25.0
  • @SocketSecurity ignore cross-fetch@3.1.6
  • @SocketSecurity ignore cross-fetch@4.0.0

@jlazoff
Copy link
Contributor

jlazoff commented Dec 1, 2023

Hi @cuonglt-ync @tannn-younet ,
Please comment on this code review.
Thank you so much,
Joshua

@Consensys Consensys closed this by deleting the head repository Dec 1, 2023
Copy link

@nkkurt nkkurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please don't deploy with my review alone.

blaiseup pushed a commit that referenced this pull request May 31, 2024
…cond-to-feature-slider

Support CTA second for FeatureSlider module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants