Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pull slug for developers news #396

Merged
merged 1 commit into from
Jul 2, 2024
Merged

fix: pull slug for developers news #396

merged 1 commit into from
Jul 2, 2024

Conversation

blaiseup
Copy link
Contributor

@blaiseup blaiseup commented Jul 1, 2024 •
edited
Loading

nkkurt
nkkurt reviewed Jul 1, 2024
View reviewed changes
Copy link

@nkkurt nkkurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blaiseup
Copy link
Contributor Author

blaiseup commented Jul 1, 2024

Hi @viphan007,

I think in this PR slug was introduced for news categories: https://github.com/MetaMask/website/pull/391/files
I expect this PR to fix the issue referenced above, but please check the whole query to make sure.

Thanks,
Balazs

@tannn-younet tannn-younet merged commit fbed622 into master Jul 2, 2024
5 checks passed
@tannn-younet tannn-younet deleted the hotfix-latest-news-section-on-develop-page branch July 2, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannn-younet tannn-younet tannn-younet approved these changes

@kevin-chassagne kevin-chassagne Awaiting requested review from kevin-chassagne

@viphan007 viphan007 Awaiting requested review from viphan007

@nkkurt nkkurt Awaiting requested review from nkkurt

@cuonglt-ync cuonglt-ync Awaiting requested review from cuonglt-ync

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blaiseup @nkkurt @tannn-younet