-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.5 models, views, templates and ancillary files #510
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a lot of great work in here, @fgregg. Thank you!
Several of the inline comments are related to a more robust Membership manager. I think this could help reduce duplicate code and make accessing subsets of memberships a lot easier to perform and read. LMK if you want to chat more about that.
Very excited to see what you've accomplished separately with the map and management commands.
Co-Authored-By: Hannah Cushman <hancush@users.noreply.github.com>
@hancush thank you for the review! I've addressed some of your very good suggestions. Others, at your approval, I would like to defer to other PRs. I do think that we should resolve the infelicities around pre-fetching in this PR, but I require your more detailed guidance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to wrap this up for the day. With the exception of one outstanding thread (https://github.com/datamade/la-metro-councilmatic/pull/510/files#r350337543) You've addressed all of my comments, @fgregg. Thank you very, very much for your work and willingness to discuss and make changes! 🎊
Here's a quick summary of things to accomplish later:
- In a separate PR, define a Membership manager with custom methods for membership and leadership posts and the display order annotation.
- Open a how-to issue with links to your riff on our Docker approach. 2.5 models, views, templates and ancillary files #510 (comment)
- Add history fallback logic to the scraper updates. 2.5 models, views, templates and ancillary files #510 (comment)
- Update the README when we're ready to bring in the complete upgrade. 2.5 models, views, templates and ancillary files #510 (comment)
Overview
This PR makes changes to the models, views, templates, urls and ancillary files for the councilmatic 2.5 upgrade. This PR does not include the map view for the board members page, which will come in a separate PR.
Notes
This PR depends on changes to the scrapers and django-councilmatic. I believe they can be reviewed separately
Also, we are bit out of synch with LA metro master, we should discuss how we want to handle that.
Testing Instructions
Move
councilmatic/settings_deployment.py.example
tocouncilmatic/settings_deployment.py
.