Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Add-KdsRootKey.md #2951

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Update Add-KdsRootKey.md #2951

merged 2 commits into from
Oct 3, 2023

Conversation

Natfan
Copy link
Contributor

@Natfan Natfan commented Apr 26, 2022

Modified the EffectiveTime parameter example, to include a day larger than 12. This should prevent confusion over the format to use (recommended as the American mm/dd/yyyy format, however any format should work as the parameter takes a DateTime, not a string)

Modified the EffectiveTime parameter example, to include a day larger than 12. This should prevent confusion over the format to use (recommended as the American mm/dd/yyyy format, however any format should work as the parameter takes a DateTime, not a string)
@opbld32
Copy link

opbld32 commented Apr 26, 2022

Docs Build status updates of commit e70e043:

✅ Validation status: passed

File Status Preview URL Details
docset/winserver2022-ps/kds/Add-KdsRootKey.md ✅Succeeded View (WindowsServer2022-ps)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@o0nj o0nj assigned ghost , get-itips and dariomws Aug 16, 2022
Copy link
Contributor

@get-itips get-itips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Natfan Can you check and make the same edit in the other OS versions of the same cmdlet article? Thanks for your contribution.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if it would be useful to re-write this example to be generic, i.e., Add-KdsRootKey -EffectiveTime (Get-Date).AddDays(12) and adding Get-Date to Related Links.

Regardless, this works, too. Thanks!

@scanum
Copy link

scanum commented Oct 2, 2023

@tiburd
PR has been copyedited and is ready for final review, could you please check and merge? Thanks!

@scanum scanum assigned tiburd and unassigned ghost , dariomws and get-itips Oct 2, 2023
@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit a328a12:

✅ Validation status: passed

File Status Preview URL Details
docset/winserver2022-ps/kds/Add-KdsRootKey.md ✅Succeeded View (WindowsServer2022-ps)

For more details, please refer to the build report.

For any questions, please:

@tiburd tiburd merged commit 0d156c6 into MicrosoftDocs:main Oct 3, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants