Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves #2825 #2966

Merged
merged 3 commits into from
Oct 3, 2023
Merged

Resolves #2825 #2966

merged 3 commits into from
Oct 3, 2023

Conversation

velkovb
Copy link
Contributor

@velkovb velkovb commented May 10, 2022

Move WhatIf note in cmdlet description
NOTE: The WhatIf switch does not work with this cmdlet.

@opbld33
Copy link

opbld33 commented May 10, 2022

Docs Build status updates of commit 54cbd7d:

✅ Validation status: passed

File Status Preview URL Details
docset/winserver2012-ps/smbshare/New-SmbShare.md ✅Succeeded View (winserver2012-ps)
docset/winserver2012r2-ps/smbshare/New-SmbShare.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2016-ps/smbshare/New-SmbShare.md ✅Succeeded View (WindowsServer2016-ps)
docset/winserver2019-ps/smbshare/New-SmbShare.md ✅Succeeded View (WindowsServer2019-ps)
docset/winserver2022-ps/smbshare/New-SmbShare.md ✅Succeeded View (WindowsServer2022-ps)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@o0nj o0nj assigned get-itips, ghost , dariomws and o0nj Jun 8, 2022
Copy link
Contributor

@sdwheeler sdwheeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the Alert box format for notes like this.

docset/winserver2012-ps/smbshare/New-SmbShare.md Outdated Show resolved Hide resolved
docset/winserver2012r2-ps/smbshare/New-SmbShare.md Outdated Show resolved Hide resolved
docset/winserver2016-ps/smbshare/New-SmbShare.md Outdated Show resolved Hide resolved
docset/winserver2019-ps/smbshare/New-SmbShare.md Outdated Show resolved Hide resolved
docset/winserver2022-ps/smbshare/New-SmbShare.md Outdated Show resolved Hide resolved
@velkovb
Copy link
Contributor Author

velkovb commented Jun 10, 2022

Please use the Alert box format for notes like this.

@sdwheeler I have been advised in the past not to use this syntax as it does not render in PowerShell. Should I start using it?

@sdwheeler
Copy link
Contributor

Should I start using it?

Yes, the Alert boxes are the preferred format.

@opbld31
Copy link

opbld31 commented Jun 10, 2022

Docs Build status updates of commit a626788:

✅ Validation status: passed

File Status Preview URL Details
docset/winserver2012-ps/smbshare/New-SmbShare.md ✅Succeeded View (winserver2012-ps)
docset/winserver2012r2-ps/smbshare/New-SmbShare.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2016-ps/smbshare/New-SmbShare.md ✅Succeeded View (WindowsServer2016-ps)
docset/winserver2019-ps/smbshare/New-SmbShare.md ✅Succeeded View (WindowsServer2019-ps)
docset/winserver2022-ps/smbshare/New-SmbShare.md ✅Succeeded View (WindowsServer2022-ps)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

velkovb and others added 2 commits June 10, 2022 10:15
Move WhatIf note in cmdlet description
NOTE: The WhatIf switch does not work with this cmdlet.
Co-authored-by: Sean Wheeler <sean.wheeler@microsoft.com>
@opbld31
Copy link

opbld31 commented Jun 10, 2022

Docs Build status updates of commit dd6d4eb:

✅ Validation status: passed

File Status Preview URL Details
docset/winserver2012-ps/smbshare/New-SmbShare.md ✅Succeeded View (winserver2012-ps)
docset/winserver2012r2-ps/smbshare/New-SmbShare.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2016-ps/smbshare/New-SmbShare.md ✅Succeeded View (WindowsServer2016-ps)
docset/winserver2019-ps/smbshare/New-SmbShare.md ✅Succeeded View (WindowsServer2019-ps)
docset/winserver2022-ps/smbshare/New-SmbShare.md ✅Succeeded View (WindowsServer2022-ps)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@scanum
Copy link

scanum commented Oct 2, 2023

@tiburd
PR has been copyedited and is ready for final review, could you please check and merge? Thanks!

@scanum scanum assigned tiburd and unassigned o0nj, ghost , dariomws and get-itips Oct 2, 2023
@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 60f7e46:

✅ Validation status: passed

File Status Preview URL Details
docset/winserver2012-ps/smbshare/New-SmbShare.md ✅Succeeded View (winserver2012-ps)
docset/winserver2012r2-ps/smbshare/New-SmbShare.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2016-ps/smbshare/New-SmbShare.md ✅Succeeded View (WindowsServer2016-ps)
docset/winserver2019-ps/smbshare/New-SmbShare.md ✅Succeeded View (WindowsServer2019-ps)
docset/winserver2022-ps/smbshare/New-SmbShare.md ✅Succeeded View (WindowsServer2022-ps)

For more details, please refer to the build report.

For any questions, please:

@tiburd tiburd merged commit 4bafb8f into MicrosoftDocs:main Oct 3, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants