Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruby 3.3 gem to CI #603

Merged
merged 2 commits into from
Jan 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby: ["3.2", "3.1", "3.0", "2.7"]
ruby: ["3.3", "3.2", "3.1", "3.0", "2.7"]
redis: ["5.x"]
steps:
- uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion Guardfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# More info at https://github.com/guard/guard#readme

directories %w(lib spec) \
.select { |d| Dir.exists?(d) ? d : UI.warning("Directory #{d} does not exist") }
.select { |d| Dir.exist?(d) ? d : UI.warning("Directory #{d} does not exist") }

## Note: if you are using the `directories` clause above and you are not
## watching the project directory ('.'), then you will want to move
Expand Down
2 changes: 2 additions & 0 deletions lib/mini_profiler/config.rb
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,9 @@ def self.default

# redefined - since the accessor defines it first
undef :authorization_mode=
# rubocop:disable Lint/DuplicateMethods
def authorization_mode=(mode)
# rubocop:enable Lint/DuplicateMethods
if mode == :whitelist
warn "[DEPRECATION] `:whitelist` authorization mode is deprecated. Please use `:allow_authorized` instead."

Expand Down
2 changes: 2 additions & 0 deletions lib/mini_profiler/snapshots_transporter.rb
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,11 @@ class << self
def transported_snapshots_count
@@transported_snapshots_count
end

def successful_http_requests_count
@@successful_http_requests_count
end

def failed_http_requests_count
@@failed_http_requests_count
end
Expand Down
2 changes: 0 additions & 2 deletions lib/mini_profiler/storage/file_store.rb
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,6 @@ def initialize(args = nil)
end

at_exit { t[:should_exit] = true }

t
end

def save(page_struct)
Expand Down
1 change: 0 additions & 1 deletion lib/mini_profiler/timer_struct/base.rb
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ def [](name)

def []=(name, val)
attributes[name] = val
self
end

def to_json(*a)
Expand Down
2 changes: 1 addition & 1 deletion lib/mini_profiler/views.rb
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ def get_profile_script(env)
script = ::File.read(::File.expand_path('../html/profile_handler.js', ::File.dirname(__FILE__)))
# replace the variables
settings.each do |k, v|
regex = Regexp.new("\\{#{k.to_s}\\}")
regex = Regexp.new("\\{#{k}\\}")
script.gsub!(regex, v.to_s)
end

Expand Down