Sending deviceID for outputs instead of pin number #1886
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build for this pull request: |
|
Is this not a breaking change correct? Everything continue to work properly if users don't upgrade their firmware and continue to use older firmware with newer desktop app? |
|
Yes, correct. |
|
I think it would be cleaner to have a deprecated class which uses the old logic, and the new class which does it the new way. overriding just the |
|
Build for this pull request: |
|
A new PR will be issued which includes the proposed changes. The branch is already set up from @DocMoebiuz , see branch The changes are already tested successful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of sending a pin number for outputs the deviceID is send like for all other devices. This is for harmaonization and possible future extensions.
PR MobiFlight/MobiFlight-FirmwareSource#346 must be merged at the same time.
Fixes #1885