Skip parsing of section attachments for logs with version less than 11 #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeEAaD
requested review from
polac24,
ecamacho,
aleksandergrzyb and
CognitiveDisson
as code owners
HeEAaD
force-pushed
the
skip_ActivityLogSectionAttachment_for_version_10
branch
from
ce3ae52 to
58803b9
Compare
|
@polac24 @ecamacho @aleksandergrzyb @CognitiveDisson Hi guys! Could you please review this pull request? It's impossible to use XCLogParser on Xcode before 15.3 without it. |
aleksandergrzyb
approved these changes
Sep 17, 2024
|
Up! @polac24 @ecamacho @aleksandergrzyb @CognitiveDisson Hi guys! Could you please review this pull request? |
|
Up! @polac24 @ecamacho @CognitiveDisson please 🙏 |
|
@HeEAaD I was able to pull your branch and build locally and this fixes an issue I have. Is there any chance you could re-base so we could get this merged and a new version cut? |
HeEAaD
force-pushed
the
skip_ActivityLogSectionAttachment_for_version_10
branch
from
58803b9 to
987ed38
Compare
|
@aleksandergrzyb @kalebhermes I've just rebased. Unit tests succeeded locally. Please approve the workflow run. |
aleksandergrzyb
approved these changes
Dec 11, 2024
|
We also had to upgrade macOS version, could you rebase on #222? |
Signed-off-by: Steffen Matthischke <HeEAaD@users.noreply.github.com>
HeEAaD
force-pushed
the
skip_ActivityLogSectionAttachment_for_version_10
branch
from
987ed38 to
ba46699
Compare
done |
aleksandergrzyb
merged commit 251e44b
into
MobileNativeFoundation:master
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #211
Fixes #209
This resolves the regression introduced by #204 that parsing of older logs (pre Xcode 15.3) raises the error
Unexpected token parsing array of IDEActivityLogSectionAttachment.Parse the
IDEActivityLogSectionAttachmentslist only for activity logs with version 11 or above because this list is missing in version 10 logs.Thanks @yohunl for the inspiration for the fix. #209 (comment)