Workflow updates #161
Merged
Workflow updates #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the expected schema for config.yml, so timeseries.case_name should be a list. Also, needed to set data_sources.nb_path_root and strip casename from global_params.CESM_output_dir
- Moved climo_nyears and base_climo_nyears to glc section - glacier notebook now uses obs_path for reading in more data - time-series section points to both new run and base case
If one of the case names in the timeseries section of the config file matches
base_case_name, look for output in base_case_output_dir instead of
CESM_output_dir.
Also, one of the strings used when raising an exception was meant to be an
f-string (it includes a {variable} but was missing the f").
When generating the ADF config file, base_case_output_dir was missing base_case_name in the path
The coupling index was being written to Meg's scratch space on derecho; now we look for $SCRATCH and write in a subdirectory ($SCRATCH/CUPiD_scratch) otherwise we write in $PWD
Found a bug in reading the data -- we want to use (base_start_date, base_end_date) as the date range for the base_case data read, not (start_date, end_date). Also, for some reason I needed to .load() the data before calling .rolling() -- it's not clear to me why this was necessary but it avoided an Exception being raised from that function
For CESM workflow, when generating an ADF config file, we want to point to the CUPiD config file in the current case directory rather than the example it was generated from
mnlevy1981
commented
Dec 20, 2024
There was a problem hiding this comment.
@megandevlan Can you take a look at the changes I made in Global_TerrestrialCouplingIndex_VisualCompareObs.ipynb? I hadn't noticed before, but you were writing the coupling index to your own scratch space
|
This looks good to me, @mnlevy1981! Makes a lot more sense to do it this way. |
1. adf_root should be a subdirectory of case_root 2. All components should use end_year and base_end_year for time series, not just atm 3. Look to see if specific notebooks are in template config file before changing parameters for them
TeaganKing
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Updates necessary to include CUPiD as part of the CESM workflow
pre-commitchecks passed (#8 in Adding Notebooks Guide)?