Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

專案架構 #115

Merged
merged 6 commits into from
Oct 3, 2024
Merged

專案架構 #115

merged 6 commits into from
Oct 3, 2024

Conversation

1989ONCE
Copy link
Member

@1989ONCE 1989ONCE commented Sep 24, 2024

  1. Figuring out how routes, supabase works
  2. add sidemenu for page switching

Summary by CodeRabbit

Release Notes

  • New Features

    • Introduced new components: Center, HStack, VStack, Image, DrawerOption, DrawerSideBar, Header, BasicIcon, CalendarIcon, LogoutIcon, and SidebarArrowDownIcon.
    • Added new routes for /calendar/, /dinner/, /map/, /sales/, and /home/infoCard with authentication guards.
  • Enhancements

    • Updated .gitignore to exclude unnecessary files and directories.
    • Integrated supabase and daisyui packages for enhanced functionality and styling.
  • Bug Fixes

    • Removed outdated Button and HStack components to streamline the codebase.
  • Chores

    • Updated package.json dependencies and improved the structure of route exports for better organization.

daviddaytw
daviddaytw previously approved these changes Sep 27, 2024
Copy link
Member

@daviddaytw daviddaytw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@daviddaytw daviddaytw changed the title testing 專案架構 Oct 2, 2024
@1989ONCE 1989ONCE merged commit 702ffcd into NCUAppTeam:main Oct 3, 2024
2 checks passed
1989ONCE added a commit to 1989ONCE/NCU-App that referenced this pull request Oct 18, 2024
@1989ONCE 1989ONCE added the structure refactor, db model design label Dec 2, 2024
Copy link
Contributor

coderabbitai bot commented Dec 2, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request introduces several significant changes, including updates to the .gitignore file to exclude various editor-related files and directories, and the addition of new components such as Center, HStack, Image, VStack, and DrawerOption. It also modifies the package.json to include new dependencies, introduces new routes for calendar and dinner features, and updates the database schema with new tables and relationships. Additionally, it enhances the routing structure with authentication checks and component organization.

Changes

File Path Change Summary
.gitignore Added entries for .env, editor files, test results, and cache directories.
package.json Added dependency "supabase": "^1.200.3" and dev dependency "daisyui": "^4.12.10".
src/components/Button.tsx Removed Button component.
src/components/Common/Center.tsx Introduced Center component for centering child elements.
src/components/Common/HStack.tsx Introduced HStack component for horizontal stacking of elements.
src/components/Common/Image.tsx Introduced Image component for rendering images with props.
src/components/Common/VStack.tsx Introduced VStack component for vertical stacking of elements.
src/components/Common/customButton.tsx Introduced new Button component with customizable props.
src/components/DrawerOption.tsx Introduced DrawerOption component for navigation options with toggling functionality.
src/components/DrawerSideBar.tsx Introduced DrawerSideBar for sidebar navigation with user info and sign-out functionality.
src/components/Header.tsx Introduced Header component for user data fetching and rendering.
src/components/icons/BasicIcon.tsx Introduced BasicIcon component for rendering SVG icons.
src/components/icons/CalendarIcon.tsx Introduced CalendarIcon component extending BasicIcon.
src/components/icons/LogoutIcon.tsx Introduced LogoutIcon component extending BasicIcon.
src/components/icons/SidebarArrowDownIcon.tsx Introduced SidebarArrowDownIcon component extending BasicIcon.
src/components/icons/SidebarArrowRightIcon.tsx Introduced SidebarArrowRightIcon component extending BasicIcon.
src/components/index.ts Added exports for new components and icons for centralized access.
src/components/interface/ButtonProps.tsx Introduced ButtonProps interface for button properties.
src/components/interface/ChildrenProps.tsx Introduced ChildrenProps interface for components with children.
src/components/interface/IconProps.tsx Introduced IconProps interface for icon properties.
src/components/interface/ImageProps.tsx Introduced ImageProps interface for image component properties.
src/routeTree.gen.ts Added new routes for /, /sales/, /map/, /dinner/, /calendar/, and /home/infoCard.
src/routes/__root.tsx Updated root route implementation to use a separate RootComponent.
src/routes/calendar/index.tsx Introduced calendar route with authentication guard.
src/routes/dinner/index.tsx Introduced dinner route with authentication guard.
src/routes/events/create.tsx Updated import for Button component from customButton.
src/routes/events/index.tsx Added Header and AuthGuard to events route.
src/routes/home/infoCard.tsx Introduced new route for /home/infoCard.
src/routes/index.tsx Introduced root route with user data loader and authentication.
src/routes/login.tsx Updated layout of login page using VStack.
src/routes/map/index.tsx Introduced map route with authentication guard.
src/routes/sales/index.tsx Introduced sales route with authentication guard.
src/utils/database.types.ts Updated Database type to include new tables and relationships.
supabase/migrations/20241002170227_remote_schema.sql Created new tables event_type, identities, members, and updated events table.
supabase/seed.sql Inserted initial data into various tables for project setup.
tailwind.config.js Added daisyui plugin to Tailwind CSS configuration.

Possibly related PRs

  • update packages #129: The changes in the package.json file are related to the main PR as both involve modifications to the supabase dependency, indicating a connection in the management of project dependencies.

🐰 In the code, I hop and play,
New components brighten the way.
With buttons and icons, oh what a sight,
Our app's now a delight!
So here’s to the changes, let’s cheer and say,
CodeRabbit's magic is here to stay! 🐇✨

Warning

Rate limit exceeded

@1989ONCE has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 18 minutes and 2 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 9685f11 and 377a48d.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 9685f11 and 377a48d.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (37)
  • .gitignore (1 hunks)
  • package.json (2 hunks)
  • src/components/Button.tsx (0 hunks)
  • src/components/Common/Center.tsx (1 hunks)
  • src/components/Common/HStack.tsx (1 hunks)
  • src/components/Common/Image.tsx (1 hunks)
  • src/components/Common/VStack.tsx (1 hunks)
  • src/components/Common/customButton.tsx (1 hunks)
  • src/components/DrawerOption.tsx (1 hunks)
  • src/components/DrawerSideBar.tsx (1 hunks)
  • src/components/HStack.tsx (0 hunks)
  • src/components/Header.tsx (1 hunks)
  • src/components/icons/BasicIcon.tsx (1 hunks)
  • src/components/icons/CalendarIcon.tsx (1 hunks)
  • src/components/icons/LogoutIcon.tsx (1 hunks)
  • src/components/icons/SidebarArrowDownIcon.tsx (1 hunks)
  • src/components/icons/SidebarArrowRightIcon.tsx (1 hunks)
  • src/components/index.ts (1 hunks)
  • src/components/interface/ButtonProps.tsx (1 hunks)
  • src/components/interface/ChildrenProps.tsx (1 hunks)
  • src/components/interface/IconProps.tsx (1 hunks)
  • src/components/interface/ImageProps.tsx (1 hunks)
  • src/routeTree.gen.ts (6 hunks)
  • src/routes/__root.tsx (1 hunks)
  • src/routes/calendar/index.tsx (1 hunks)
  • src/routes/dinner/index.tsx (1 hunks)
  • src/routes/events/create.tsx (1 hunks)
  • src/routes/events/index.tsx (3 hunks)
  • src/routes/home/infoCard.tsx (1 hunks)
  • src/routes/index.tsx (1 hunks)
  • src/routes/login.tsx (2 hunks)
  • src/routes/map/index.tsx (1 hunks)
  • src/routes/sales/index.tsx (1 hunks)
  • src/utils/database.types.ts (5 hunks)
  • supabase/migrations/20241002170227_remote_schema.sql (1 hunks)
  • supabase/seed.sql (1 hunks)
  • tailwind.config.js (2 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
structure refactor, db model design
Development

Successfully merging this pull request may close these issues.

3 participants