Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat : add "hold new events" button #118

Merged
merged 2 commits into from
Oct 18, 2024
Merged

feat : add "hold new events" button #118

merged 2 commits into from
Oct 18, 2024

Conversation

NelsonKCT
Copy link
Contributor

@NelsonKCT NelsonKCT commented Oct 17, 2024 •
edited
Loading

截圖 2024-10-17 晚上8 25 35 截圖 2024-10-17 晚上8 25 41 截圖 2024-10-17 晚上8 25 48

@daviddaytw daviddaytw requested review from 1989ONCE and daviddaytw and removed request for daviddaytw and rryh-tw October 18, 2024 06:38
1989ONCE
1989ONCE approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@1989ONCE 1989ONCE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job! Later on, please try to make the modal into components for readability and maintainability.

@1989ONCE 1989ONCE merged commit d559702 into NCUAppTeam:main Oct 18, 2024
2 checks passed
1989ONCE added a commit to 1989ONCE/NCU-App that referenced this pull request Oct 18, 2024
@1989ONCE
Merge pull request NCUAppTeam#118 from NelsonKCT/main
1720afb 
feat : add "hold new events" button
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1989ONCE 1989ONCE 1989ONCE approved these changes

@daviddaytw daviddaytw daviddaytw approved these changes

Assignees

@NelsonKCT NelsonKCT

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NelsonKCT @daviddaytw @1989ONCE