changed get_thermal_habitat_gridded to pull from ERDDAP before format…

[jcaracappa1]

Added spatial data for GLORYS EPU mapping and bathymetry

Modified data-raw/get_thermal_habitat_gridded.R to pull from ERDDAP (need to be behind firewall to run)

[andybeet]

after sourcing the function then running the following (Note: save_clean = F)

a <- get_thermal_habitat_gridded(threshold = c(15,18.5,24),
                            year = 2023,
                            depth.bins = c(0,25,100,3000),
                            save_clean = F)

Then plotting this object using the plot function results in this

[sgaichas]

so looks like they are all the same plot, and the Value units aren't in days? catalog for reference: https://noaa-edab.github.io/catalog/thermal_habitat_persistence.html#key-results-and-visualizations-46

[andybeet]

it does look like (from inspecting the data) that the data for each plot is identical. And yes very different from catalog. Must be a bug somewhere

[jcaracappa1]

This looks fixed now

[andybeet]

a <- get_thermal_habitat_gridded(threshold = c(15,18.5,24),
                            year = 2023,
                            depth.bins = c(0,25,100,3000),
                            save_clean = F)

I think this is why the pulling and processing of the data should be in an external package (to ensure all dependencies are installed and to document if there are additional system requirements, looks like i might need a newer version of GDAL?). Then the package::function is used in the get function and all is needed is then to format the data.

[jcaracappa1]

I think it's broken because Kim is reuploading the data. It's breaking for me too. I'll test again soon

[jcaracappa1]

This should be fixed now

[andybeet]

still result in error for me and Brandon

[khyde]

@andybeet When did you try it? The ERDDAP server is currently down because of the generator work.

[andybeet]

just tried again. still errors