-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Quantity into a sub-directory #89
base: develop
Are you sure you want to change the base?
Refactor Quantity into a sub-directory #89
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
like this a lot. lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes a lot of sense to me
94b35d0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
We need to write a system that allow for the manipulation of Bundle of data (Tracers, Aerosols...). We hope to use the already establish
Quantity
to do so. This PR aims at cleaning up thequantity.py
, which was a single file mixing at least 3 different concepts. A subsequent PR will propose a "Bundle" as an extension toQuantity
Checklist: